Refactor Api::Web::SettingsController (#15717)

3 years ago · 15ced8728f
parent f8972d4503
commit 15ced8728f
1 changed files with 4 additions and 5 deletions
--- a/app/controllers/api/web/settings_controller.rb
+++ b/app/controllers/api/web/settings_controller.rb
@ -2,17 +2,16 @@

 class Api::Web::SettingsController < Api::Web::BaseController
  before_action :require_user!
+  before_action :set_setting

  def update
-    setting.data = params[:data]
-    setting.save!
-
+    @setting.update!(data: params[:data])
    render_empty
  end

  private

-  def setting
-    @_setting ||= ::Web::Setting.where(user: current_user).first_or_initialize(user: current_user)
+  def set_setting
+    @setting = ::Web::Setting.where(user: current_user).first_or_initialize(user: current_user)
  end
 end