You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

158 lines
4.0 KiB

6 years ago
6 years ago
6 years ago
6 years ago
6 years ago
Add WebAuthn as an alternative 2FA method (#14466) * feat: add possibility of adding WebAuthn security keys to use as 2FA This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor to the Settings page for editing the 2FA methods – now it will list the methods that are available to the user (TOTP and WebAuthn) and from there they'll be able to add or remove any of them. Also, it's worth mentioning that for enabling WebAuthn it's required to have TOTP enabled, so the first time that you go to the 2FA Settings page, you'll be asked to set it up. This work was inspired by the one donde by Github in their platform, and despite it could be approached in different ways, we decided to go with this one given that we feel that this gives a great UX. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add request for WebAuthn as second factor at login if enabled This commits adds the feature for using WebAuthn as a second factor for login when enabled. If users have WebAuthn enabled, now a page requesting for the use of a WebAuthn credential for log in will appear, although a link redirecting to the old page for logging in using a two-factor code will also be present. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add possibility of deleting WebAuthn Credentials Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: disable WebAuthn when an Admin disables 2FA for a user Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: remove ability to disable TOTP leaving only WebAuthn as 2FA Following examples form other platforms like Github, we decided to make Webauthn 2FA secondary to 2FA with TOTP, so that we removed the possibility of removing TOTP authentication only, leaving users with just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA' in order to remove second factor auth. The reason for WebAuthn being secondary to TOPT is that in that way, users will still be able to log in using their code from their phone's application if they don't have their security keys with them – or maybe even lost them. * We had to change a little the flow for setting up TOTP, given that now it's possible to setting up again if you already had TOTP, in order to let users modify their authenticator app – given that now it's not possible for them to disable TOTP and set it up again with another authenticator app. So, basically, now instead of storing the new `otp_secret` in the user, we store it in the session until the process of set up is finished. This was because, as it was before, when users clicked on 'Edit' in the new two-factor methods lists page, but then went back without finishing the flow, their `otp_secret` had been changed therefore invalidating their previous authenticator app, making them unable to log in again using TOTP. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * refactor: fix eslint errors The PR build was failing given that linting returning some errors. This commit attempts to fix them. * refactor: normalize i18n translations The build was failing given that i18n translations files were not normalized. This commits fixes that. * refactor: avoid having the webauthn gem locked to a specific version * refactor: use symbols for routes without '/' * refactor: avoid sending webauthn disabled email when 2FA is disabled When an admins disable 2FA for users, we were sending two mails to them, one notifying that 2FA was disabled and the other to notify that WebAuthn was disabled. As the second one is redundant since the first email includes it, we can remove it and send just one email to users. * refactor: avoid creating new env variable for webauthn_origin config * refactor: improve flash error messages for webauthn pages Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
1 year ago
6 years ago
6 years ago
6 years ago
6 years ago
6 years ago
Add follower synchronization mechanism (#14510) * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each
1 year ago
  1. # frozen_string_literal: true
  2. source 'https://rubygems.org'
  3. ruby '>= 2.5.0', '< 3.1.0'
  4. gem 'pkg-config', '~> 1.4'
  5. gem 'rexml', '~> 3.2'
  6. gem 'puma', '~> 5.5'
  7. gem 'rails', '~> 6.1.4'
  8. gem 'sprockets', '~> 3.7.2'
  9. gem 'thor', '~> 1.1'
  10. gem 'rack', '~> 2.2.3'
  11. gem 'hamlit-rails', '~> 0.2'
  12. gem 'pg', '~> 1.2'
  13. gem 'makara', '~> 0.5'
  14. gem 'pghero', '~> 2.8'
  15. gem 'dotenv-rails', '~> 2.7'
  16. gem 'aws-sdk-s3', '~> 1.106', require: false
  17. gem 'fog-core', '<= 2.1.0'
  18. gem 'fog-openstack', '~> 0.3', require: false
  19. gem 'kt-paperclip', '~> 7.0'
  20. gem 'blurhash', '~> 0.1'
  21. gem 'active_model_serializers', '~> 0.10'
  22. gem 'addressable', '~> 2.8'
  23. gem 'bootsnap', '~> 1.9.1', require: false
  24. gem 'browser'
  25. gem 'charlock_holmes', '~> 0.7.7'
  26. gem 'iso-639'
  27. gem 'chewy', '~> 7.2'
  28. gem 'cld3', '~> 3.4.2'
  29. gem 'devise', '~> 4.8'
  30. gem 'devise-two-factor', '~> 4.0'
  31. group :pam_authentication, optional: true do
  32. gem 'devise_pam_authenticatable2', '~> 9.2'
  33. end
  34. gem 'net-ldap', '~> 0.17'
  35. gem 'omniauth-cas', '~> 2.0'
  36. gem 'omniauth-saml', '~> 1.10'
  37. gem 'omniauth', '~> 1.9'
  38. gem 'omniauth-rails_csrf_protection', '~> 0.1'
  39. gem 'color_diff', '~> 0.1'
  40. gem 'discard', '~> 1.2'
  41. gem 'doorkeeper', '~> 5.5'
  42. gem 'ed25519', '~> 1.2'
  43. gem 'fast_blank', '~> 1.0'
  44. gem 'fastimage'
  45. gem 'hiredis', '~> 0.6'
  46. gem 'redis-namespace', '~> 1.8'
  47. gem 'htmlentities', '~> 4.3'
  48. gem 'http', '~> 5.0'
  49. gem 'http_accept_language', '~> 2.1'
  50. gem 'httplog', '~> 1.5.0'
  51. gem 'idn-ruby', require: 'idn'
  52. gem 'kaminari', '~> 1.2'
  53. gem 'link_header', '~> 0.0'
  54. gem 'mime-types', '~> 3.4.1', require: 'mime/types/columnar'
  55. gem 'nokogiri', '~> 1.12'
  56. gem 'nsa', '~> 0.2'
  57. gem 'oj', '~> 3.13'
  58. gem 'ox', '~> 2.14'
  59. gem 'parslet'
  60. gem 'posix-spawn'
  61. gem 'pundit', '~> 2.1'
  62. gem 'premailer-rails'
  63. gem 'rack-attack', '~> 6.5'
  64. gem 'rack-cors', '~> 1.1', require: 'rack/cors'
  65. gem 'rails-i18n', '~> 6.0'
  66. gem 'rails-settings-cached', '~> 0.6'
  67. gem 'redis', '~> 4.5', require: ['redis', 'redis/connection/hiredis']
  68. gem 'mario-redis-lock', '~> 1.2', require: 'redis_lock'
  69. gem 'rqrcode', '~> 2.1'
  70. gem 'ruby-progressbar', '~> 1.11'
  71. gem 'sanitize', '~> 6.0'
  72. gem 'scenic', '~> 1.5'
  73. gem 'sidekiq', '~> 6.3'
  74. gem 'sidekiq-scheduler', '~> 3.1'
  75. gem 'sidekiq-unique-jobs', '~> 7.1'
  76. gem 'sidekiq-bulk', '~>0.2.0'
  77. gem 'simple-navigation', '~> 4.3'
  78. gem 'simple_form', '~> 5.1'
  79. gem 'sprockets-rails', '~> 3.4', require: 'sprockets/railtie'
  80. gem 'stoplight', '~> 2.2.1'
  81. gem 'strong_migrations', '~> 0.7'
  82. gem 'tty-prompt', '~> 0.23', require: false
  83. gem 'twitter-text', '~> 3.1.0'
  84. gem 'tzinfo-data', '~> 1.2021'
  85. gem 'webpacker', '~> 5.4'
  86. gem 'webpush', '~> 0.3'
  87. gem 'webauthn', '~> 3.0.0.alpha1'
  88. gem 'json-ld'
  89. gem 'json-ld-preloaded', '~> 3.1'
  90. gem 'rdf-normalize', '~> 0.4'
  91. gem 'redcarpet', '~> 3.5'
  92. group :development, :test do
  93. gem 'fabrication', '~> 2.22'
  94. gem 'fuubar', '~> 2.5'
  95. gem 'i18n-tasks', '~> 0.9', require: false
  96. gem 'pry-byebug', '~> 3.9'
  97. gem 'pry-rails', '~> 0.3'
  98. gem 'rspec-rails', '~> 5.0'
  99. end
  100. group :production, :test do
  101. gem 'private_address_check', '~> 0.5'
  102. end
  103. group :test do
  104. gem 'capybara', '~> 3.36'
  105. gem 'climate_control', '~> 0.2'
  106. gem 'faker', '~> 2.19'
  107. gem 'microformats', '~> 4.2'
  108. gem 'rails-controller-testing', '~> 1.0'
  109. gem 'rspec-sidekiq', '~> 3.1'
  110. gem 'simplecov', '~> 0.21', require: false
  111. gem 'webmock', '~> 3.14'
  112. gem 'rspec_junit_formatter', '~> 0.4'
  113. end
  114. group :development do
  115. gem 'active_record_query_trace', '~> 1.8'
  116. gem 'annotate', '~> 3.1'
  117. gem 'better_errors', '~> 2.9'
  118. gem 'binding_of_caller', '~> 1.0'
  119. gem 'bullet', '~> 6.1'
  120. gem 'letter_opener', '~> 1.7'
  121. gem 'letter_opener_web', '~> 2.0'
  122. gem 'memory_profiler'
  123. gem 'rubocop', '~> 1.23', require: false
  124. gem 'rubocop-rails', '~> 2.12', require: false
  125. gem 'brakeman', '~> 5.1', require: false
  126. gem 'bundler-audit', '~> 0.9', require: false
  127. gem 'capistrano', '~> 3.16'
  128. gem 'capistrano-rails', '~> 1.6'
  129. gem 'capistrano-rbenv', '~> 2.2'
  130. gem 'capistrano-yarn', '~> 2.0'
  131. gem 'stackprof'
  132. end
  133. group :production do
  134. gem 'lograge', '~> 0.11'
  135. end
  136. gem 'concurrent-ruby', require: false
  137. gem 'connection_pool', require: false
  138. gem 'xorcist', '~> 1.1'