From d344f34ffb6472a9754c28f139206640ef9bcc3e Mon Sep 17 00:00:00 2001 From: Vavassor Date: Tue, 25 Jul 2017 17:35:36 -0400 Subject: [PATCH] Addendum to commit 534443d4393e60bd340a189a175ae6d445e6a375 to cancel the callbacks so they're not called after the fragment is detached. Closes #357 --- .../keylesspalace/tusky/fragment/ViewMediaFragment.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/keylesspalace/tusky/fragment/ViewMediaFragment.java b/app/src/main/java/com/keylesspalace/tusky/fragment/ViewMediaFragment.java index d8ceabb4..d92b3337 100644 --- a/app/src/main/java/com/keylesspalace/tusky/fragment/ViewMediaFragment.java +++ b/app/src/main/java/com/keylesspalace/tusky/fragment/ViewMediaFragment.java @@ -138,7 +138,7 @@ public class ViewMediaFragment extends BaseFragment { @Override public void onError() { - // if there's no image in cache, load from network and start trnasition + // if there's no image in cache, load from network and start transition // immediately. photoActionsListener.onBringUp(); @@ -153,6 +153,13 @@ public class ViewMediaFragment extends BaseFragment { return rootView; } + @Override + public void onDetach() { + super.onDetach(); + Picasso.with(getContext()) + .cancelRequest(photoView); + } + private void loadImageFromNetwork(String url, ImageView photoView) { Picasso.with(getContext()) .load(url)