From cf6a33e83ae65cbd6feaf7dc478b7d6f86d394bf Mon Sep 17 00:00:00 2001
From: Konrad Pozniak <connyduck@users.noreply.github.com>
Date: Sat, 20 Apr 2019 17:44:54 +0200
Subject: [PATCH] upgrade build tools and enable r8 full mode (#1198)

* upgrade build tools and enable r8 full mode

* fix media description in fragment_view_video
---
 .../main/res/layout/fragment_view_video.xml   | 26 +++++++++----------
 build.gradle                                  |  2 +-
 gradle.properties                             |  1 +
 3 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/app/src/main/res/layout/fragment_view_video.xml b/app/src/main/res/layout/fragment_view_video.xml
index c22944b7..3c8afbce 100644
--- a/app/src/main/res/layout/fragment_view_video.xml
+++ b/app/src/main/res/layout/fragment_view_video.xml
@@ -8,12 +8,23 @@
     android:clickable="true"
     android:focusable="true">
 
+    <VideoView
+        android:id="@+id/videoPlayer"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        app:layout_constraintLeft_toLeftOf="parent"
+        app:layout_constraintRight_toRightOf="parent"
+        app:layout_constraintTop_toTopOf="parent"
+        app:layout_constraintBottom_toBottomOf="parent"
+        android:layout_gravity="center"
+        />
+
     <TextView
         android:id="@+id/mediaDescription"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        app:layout_constraintTop_toBottomOf="@+id/toolbar"
-        app:layout_constraintBottom_toTopOf="@+id/videoPlayer"
+        android:layout_marginTop="?attr/actionBarSize"
+        app:layout_constraintTop_toTopOf="parent"
         android:background="#60000000"
         android:lineSpacingMultiplier="1.1"
         android:padding="8dp"
@@ -22,17 +33,6 @@
         android:textSize="?attr/status_text_medium"
         tools:text="Some media description" />
 
-    <VideoView
-        android:id="@+id/videoPlayer"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        app:layout_constraintLeft_toLeftOf="parent"
-        app:layout_constraintRight_toRightOf="parent"
-        app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintBottom_toBottomOf="parent"
-        android:layout_gravity="center"
-        />
-
     <ProgressBar
         android:id="@+id/progressBar"
         android:layout_width="wrap_content"
diff --git a/build.gradle b/build.gradle
index 8056f6e6..a478f9bd 100644
--- a/build.gradle
+++ b/build.gradle
@@ -8,7 +8,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta04'
-        classpath 'com.android.tools.build:gradle:3.3.2'
+        classpath 'com.android.tools.build:gradle:3.4.0'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }
diff --git a/gradle.properties b/gradle.properties
index e28b800e..e210c2a4 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -18,3 +18,4 @@ org.gradle.parallel=true
 android.enableJetifier=true
 android.useAndroidX=true
 android.enableUnitTestBinaryResources=true
+android.enableR8.fullMode=true