fix crash in NotificationsFragment when Preferences are first accessed

fixes #797
6 years ago · 62ed1a9d57
parent 974c4f37b1
commit 62ed1a9d57
2 changed files with 8 additions and 2 deletions
--- a/app/src/main/java/com/keylesspalace/tusky/adapter/NotificationsAdapter.java
+++ b/app/src/main/java/com/keylesspalace/tusky/adapter/NotificationsAdapter.java
@ -233,6 +233,10 @@ public class NotificationsAdapter extends RecyclerView.Adapter {
        mediaPreviewEnabled = enabled;
    }

+    public boolean isMediaPreviewEnabled() {
+        return mediaPreviewEnabled;
+    }
+
    public interface NotificationActionListener {
        void onViewAccount(String id);

--- a/app/src/main/java/com/keylesspalace/tusky/fragment/NotificationsFragment.java
+++ b/app/src/main/java/com/keylesspalace/tusky/fragment/NotificationsFragment.java
@ -522,8 +522,10 @@ public class NotificationsFragment extends SFragment implements
            }
            case "mediaPreviewEnabled": {
                boolean enabled = sharedPreferences.getBoolean("mediaPreviewEnabled", true);
-                adapter.setMediaPreviewEnabled(enabled);
-                fullyRefresh();
+                if (enabled != adapter.isMediaPreviewEnabled()) {
+                    adapter.setMediaPreviewEnabled(enabled);
+                    fullyRefresh();
+                }
                break;
            }
        }