From a489b46679e48a0181084ce6b51508d93bae7d96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tu=C4=9Frul=20Gen=C3=A7o=C4=9Flu?=
 <gencoglutugrul@gmail.com>
Date: Sat, 11 Apr 2020 03:23:05 +0300
Subject: [PATCH 1/3] stop pdf share button added

---
 src/lib/PdfShare.vue | 21 +++++++++++++++++++++
 src/lib/VueJanus.vue |  5 ++++-
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/src/lib/PdfShare.vue b/src/lib/PdfShare.vue
index 88ae936..2e3cb0c 100644
--- a/src/lib/PdfShare.vue
+++ b/src/lib/PdfShare.vue
@@ -15,6 +15,11 @@
         <v-btn v-if="pdf && !loading" :disabled="pageNumber ==1" @click="prevPage" icon><v-icon>mdi-chevron-left</v-icon></v-btn>
         <span v-if="pdf && !loading">{{pageNumber}} / {{pdf.numPages}}</span>
         <v-btn v-if="pdf && !loading" :disabled="pdf.numPages == pageNumber" @click="nextPage" icon><v-icon>mdi-chevron-right</v-icon></v-btn>
+        <v-row>
+            <v-col cols="12" md="12">
+                <v-btn v-if="pdf && !loading" @click="stop">stop pdf share</v-btn>
+            </v-col>
+        </v-row>
     </div>
 </template>
 
@@ -31,6 +36,7 @@ export default {
     name: "PdfShare",
     props: {
       janusInit: Object,
+      onstop: Function,
       username: String,
       myrivid: Number,
       room: Number,
@@ -95,6 +101,21 @@ export default {
             pluginHandle.send({"message": register});
 
         },
+        stop(){
+            var unpublish = { "request": "unpublish"};
+            this.pluginHandle.send({"message": unpublish});
+
+            this.pluginHandle.detach();
+
+            // reset
+            this.pluginHandle = null;
+            this.pdf = null;
+            this.pageNumber = 1;
+            this.loading = true;
+
+            // callback
+            this.onstop();
+        },
         janusPluginError (error) {
             console.log('error', error)
         },
diff --git a/src/lib/VueJanus.vue b/src/lib/VueJanus.vue
index 9ae7fdd..a5a0a91 100644
--- a/src/lib/VueJanus.vue
+++ b/src/lib/VueJanus.vue
@@ -6,7 +6,7 @@
         <v-btn @click="screenShareStop" v-if="screenShareStarted">stop screen share</v-btn>
 
         <v-btn @click="sharePdf=true">share a pdf</v-btn>
-        <PdfShare v-if="sharePdf" :username="username"  :opaque-id="opaqueId" :room="room" :janus-init="janusInit" ></PdfShare>
+        <PdfShare v-if="sharePdf" :username="username" :onstop="stopSharePdf" :opaque-id="opaqueId" :room="room" :janus-init="janusInit" ></PdfShare>
 
         <v-dialog
                 v-model="mozillaAlert"
@@ -155,6 +155,9 @@
 
         },
         methods: {
+            stopSharePdf(){
+                this.sharePdf=false;
+            },
             webrtcState (on) {
                 this.pluginHandle.send({"message": { "request": "configure", "bitrate": 512*1000 }});
                 console.log(on, "webrt")

From 3ccb00031c7f940a80f2e95bbf9f4c98c21d08a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tu=C4=9Frul=20Gen=C3=A7o=C4=9Flu?=
 <gencoglutugrul@gmail.com>
Date: Sat, 11 Apr 2020 03:42:35 +0300
Subject: [PATCH 2/3] fixed: stop button was not hidden when screen sharing
 aborted

---
 src/lib/VueJanus.vue | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/VueJanus.vue b/src/lib/VueJanus.vue
index a5a0a91..0537e0d 100644
--- a/src/lib/VueJanus.vue
+++ b/src/lib/VueJanus.vue
@@ -194,6 +194,8 @@
                 }
             },
             onlocalstreamScreen (stream) {
+                if(!this.screenShareStarted)
+                    this.screenShareStarted=true;
                 this.$refs.ownstreamscreen.srcObject = stream
             },
             shareScreenStart (capture) {
@@ -211,7 +213,6 @@
                         onlocalstream: this.onlocalstreamScreen
                     }
                 )
-                this.screenShareStarted=true;
             },
             screenShareStop(){
                 var srcObject=this.$refs.ownstreamscreen.srcObject;

From 1754d57839ccf514484310f0dfd6717409b8d525 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tu=C4=9Frul=20Gen=C3=A7o=C4=9Flu?=
 <gencoglutugrul@gmail.com>
Date: Sat, 11 Apr 2020 04:10:44 +0300
Subject: [PATCH 3/3] fixed: screen share buttons overflowing from dialog

---
 src/lib/VueJanus.vue | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/lib/VueJanus.vue b/src/lib/VueJanus.vue
index 0537e0d..e68bead 100644
--- a/src/lib/VueJanus.vue
+++ b/src/lib/VueJanus.vue
@@ -10,7 +10,7 @@
 
         <v-dialog
                 v-model="mozillaAlert"
-                max-width="290"
+                max-width="410"
         >
             <v-card>
                 <v-card-title class="headline">Share whole screen or a window?</v-card-title>
@@ -19,13 +19,16 @@
                     Firefox handles screensharing in a different way: are you going to share the whole screen, or would you rather pick a single window/application to share instead?
                 </v-card-text>
                 <v-card-actions>
+                    <v-spacer></v-spacer>
                     <v-btn @click="shareScreenStart('screen')">Share a screen</v-btn>
+                    <v-spacer></v-spacer>
                     <v-btn @click="shareScreenStart('window')">Share a window</v-btn>
+                    <v-spacer></v-spacer>
                 </v-card-actions>
             </v-card>
         </v-dialog><v-dialog
                 v-model="chromeAlert"
-                max-width="290"
+                max-width="410"
         >
             <v-card>
                 <v-card-title class="headline">Chrome Extension Error</v-card-title>